From: Carlos Rica Date: Tue, 17 Mar 2009 11:12:55 GMT Subject: Re: [PATCH] config: test for --replace-all with one argument and fix documentation. Message-ID: <1b46aba20903170412u69041a71h3ccd97d0b61390d2@mail.gmail.com> In-Reply-To: On Tue, Mar 17, 2009 at 11:24 AM, Johannes Schindelin wrote: > Hi, > > On Tue, 17 Mar 2009, Carlos Rica wrote: > >> Option --replace-all only allows at least two arguments, so >> documentation was needing to be updated accordingly. A test showing >> that the command fails with only one parameter is also provided. >> >> Signed-off-by: Carlos Rica > > Looks obviously correct to me. I am actually unsure if I can ACK this > patch, as most of builtin-config.c does not look all that familiar to me > anymore ;-) Thank you Johannes, I think that you don't need to do it in this patch, I talked before with Junio and Felipe for this, and I think that Junio is also following the whole change (my change here is not comparable with the work of Felipe). I just added you because Felipe Contreras said that you made some suggestions to make this use of parse options possible. See you!