From: Carlos Rica Date: Mon, 16 Mar 2009 14:41:35 GMT Subject: Re: [PATCH] config: --replace-all with one argument exits properly with a better message. Message-ID: <1b46aba20903160741y64598f92gda5cfe9c8dd31586@mail.gmail.com> In-Reply-To: <94a0d4530903150326u34a0715v38269417e2785db8@mail.gmail.com> Hi Felipe, I didn't know that you were writing the parse options for config. I tried it a year ago and I leave it unfinished because (if I remember correctly) options like -4, -5, -6... and those: http://thread.gmane.org/gmane.comp.version-control.git/78480 On Sun, Mar 15, 2009 at 11:26 AM, Felipe Contreras wrote: > On Sun, Mar 15, 2009 at 3:53 AM, Junio C Hamano wrote: >> Felipe Contreras writes: >> >>> On Sat, Mar 14, 2009 at 10:53 PM, Junio C Hamano wrote: >>>> Carlos Rica writes: >>>> >>>>> 'config --replace-all ONE_ARG' was being treated as 'config NAME VALUE', >>>>> showing the error "key does not contain a section: --replace-all". >>>> >>>> Hmm, I am getting "error: wrong number of arguments" followed by the long >>>> and somewhat annoying "usage" from the parseopt table dump. >>> >>> If you find it annoying why don't you remove the usage? >> >> Because the primary target audience of the help text is not me? > > Ok. I don't think it makes a big difference to leave it on or off. > People not familiar with 'git config' might find it handy, but I admit > that I also find it a bit annoying, mainly because the error message > gets lost in the noise. > >>>> Can you work with Felipe to see if this is still needed, or needs to be >>>> fixed in a different way? It could be that your tests may already pass >>>> over there on 'next'. I didn't check. >>> >>> The new code is already checking correctly that --replace-all needs at >>> least two arguments. However, the "usage" is incorrect and of course >>> the test will come in handy. >> >> So perhaps you can pick a part of it and send in an update to your >> parseoptification series? I think the series is ready for 'master' >> sometime next week if not sooner. > > Or maybe Carlos can beat me to do it since it seems he is interested. > Otherwise yeah, I'll do it. Of course, I'm looking at your code in "pu" to see how could apply this.