From: Carlos Rica <jasampler@gmail.com>
Date: Sun, 02 Mar 2008 12:37:38 GMT
Subject: Re: [PATCH] Make builtin-reset.c use parse_options.
Message-ID: <1b46aba20803020437p2a5128a5wfee3e98c32c1a610@mail.gmail.com>
In-Reply-To: <7vir05x2di.fsf@gitster.siamese.dyndns.org>

On Sun, Mar 2, 2008 at 3:53 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Carlos Rica <jasampler@gmail.com> writes:
>
>  > Signed-off-by: Carlos Rica <jasampler@gmail.com>
>
>  Hmmm.  "git reset -h" now defaults to --hard?
>
>  It somehow feels a bit risky for new people.  I dunno.
>

I don't understand what do you mean.

Option -h just prints the options and exits.
Do you mean that the help message is wrong?

Also, there is a test to check that "git reset" defaults to
--mixed ('--mixed reset to HEAD should unadd the files'
only run a "git reset" without parameters),
and changing it to do a --hard reset makes the tests to fail.

If there's a change in the behaviour of the command,
please, show me how to test it. I cannot see anything
wrong now.

-- Carlos