From: Carlos Rica Date: Mon, 26 Nov 2007 04:51:47 GMT Subject: Re: [PATCH] "git-tag -s" should create a signed annotated tag Message-ID: <1b46aba20711252051x5ec7398er6806f21e179583d4@mail.gmail.com> In-Reply-To: <7vprxxj4hl.fsf@gitster.siamese.dyndns.org> On Nov 26, 2007 12:21 AM, Junio C Hamano wrote: > The earlier patch 396865859918e9c7bf8ce74aae137c57da134610 (Make > builtin-tag.c use parse_options.) broke "git-tag -s". > > * It's _very_ disturbing that the testsuite did not catch this > breakage, even though I though we had a very detailed coverage for > "git tag" when it was rewritten in C. Yes, you're right, "-s" without -m or -F is creating lightweight tags in my proposal. I think it is due to the absence of tests checking the "editor" option, that is, calls without -m or -F options to provide the message, since the tests are using only those and they are enabling automatically the creation of annotated tags. I need to think in adding tests replacing the editor with a custom command to check also the correct behaviour of git-tag when the EDITOR and/or the other variables are set. At the end, I've learned that it's better to test a little of every feature than test completely only a few of them. Thank you.