From: Carlos Rica <jasampler@gmail.com>
Date: Wed, 27 Jun 2007 05:54:46 GMT
Subject: Re: [PATCH 1/2] Add test script for git-stripspace.
Message-ID: <1b46aba20706262254t356fab01x5282cdd5942c4b79@mail.gmail.com>
In-Reply-To: <7v8xa6ruu4.fsf@assigned-by-dhcp.pobox.com>

2007/6/27, Junio C Hamano <gitster@pobox.com>:
> Thanks.  That's extensive set of tests for a little utility.

I hope not being overtesting the program. In order to reuse the
function that does this job from the builtins, perhaps we need another
implementation doing the same in a memory buffer instead a file
stream. The tests save the need to feed manually the program in this
development, and clarify the expected behaviour for the utility.

> > new file mode 100644
> 100755?

> > +    cat expect | git-stripspace >actual &&
> Please don't cat a single file into a pipeline.
>         git-stripspace <actual >expect

Thank you for your corrections. I Will resend it with those fixed.