From: Derrick Stolee Date: Wed, 01 Jul 2026 14:21:32 GMT Subject: Re: [PATCH 2/3] revision: avoid leaking bloom keyvecs with multiple traversals Message-ID: <1b261cfd-c9cb-44bd-a3a1-e653b2cd34ad@gmail.com> In-Reply-To: <20260701064052.GB2580331@coredump.intra.peff.net> On 7/1/2026 2:40 AM, Jeff King wrote: > In prepare_revision_walk(), we convert the pruning pathspecs into > bloom-filter "keyvecs" via prepare_to_use_bloom_filter(). This allocates > memory which is then freed eventually by release_revisions(), via > release_revisions_bloom_keyvecs(). > static void prepare_to_use_bloom_filter(struct rev_info *revs) > { > + release_revisions_bloom_keyvecs(revs); > + I continue to support the obviously-correct and simple solution to these leaks. Thanks, -Stolee