From: ronan@rjp.ie Date: Tue, 15 Nov 2022 16:32:03 GMT Subject: Re: [PATCH v2] maintenance --unregister: fix uninit'd data use & -Wdeclaration-after-statement Message-ID: <1ab6aa0e8178c88689f26b8df9ec75cb@rjp.ie> In-Reply-To: November 15, 2022 9:04 AM, "Ævar Arnfjörð Bjarmason" wrote: > Since (maintenance: add option to register in a specific config, > 2022-11-09) we've been unable to build with "DEVELOPER=1" without > "DEVOPTS=no-error", as the added code triggers a > "-Wdeclaration-after-statement" warning. > > And worse than that, the data handed to git_configset_clear() is > uninitialized, as can be spotted with e.g.: Sorry, I'm a little confused. I had sent v1, v2, and v3 of the "maintenance: add option [...]" patch, but as I understand it v2 had already been applied so I was asked to resubmit the changes from v3 rebased on next. I had done that in [1], but these issues were caught in review so I submitted a v2 of that correction in [2] which declares the configsset earlier and unconditionally initializes it is cleared. Are these further issues discovered after [2] was applied, or was there some issue rebasing the patches? [1] https://lore.kernel.org/git/20221110225310.7488-1-ronan@rjp.ie/ [2] https://lore.kernel.org/git/20221111231910.26769-1-ronan@rjp.ie/