From: Tor Arvid Lund Date: Mon, 16 Feb 2009 10:18:06 GMT Subject: Re: A little mystery - crash caused by empty commit message. Message-ID: <1a6be5fa0902160218r65965c18nd3ee90d040702b9@mail.gmail.com> In-Reply-To: <20090210153048.GA17660@coredump.intra.peff.net> On Tue, Feb 10, 2009 at 4:30 PM, Jeff King wrote: > On Tue, Feb 10, 2009 at 01:58:43PM +0100, Tor Arvid Lund wrote: > >> So - after the "+0100" on the committer line, hd tells me (as >> expected) that I have 0a 0a before "[HIA]". On the "faulty" commit I, >> for some reason, have 0a 00 instead. I do not understand why, but I >> guess strchr will return NULL when "\0[HIA]....." is passed to it, and >> segfault on the next iteration. >> >> So - I am no closer to understanding what got me to this state, but >> your reply was helpful anyway, thanks :-) > > Well, it certainly seems like a bug in one of the history-rewriting > programs. Can you try rebasing, cherry-picking, etc on the original > version of the commit to see if you can reproduce the breakage? Hi, I haven't had much time to test this thoroughly, but my primary suspect is now git-p4 in conjunction with python v2.6, which I recently installed. I will try to find some time to investigate further, and let you all know for sure. -Tor Arvid-