From: Phillip Wood <phillip.wood123@gmail.com>
Date: Fri, 16 Aug 2024 13:38:22 GMT
Subject: Re: [PATCH v5 8/9] t/unit-tests: convert strvec tests to use clar
Message-ID: <1a38638e-561b-4e97-a462-f5ff034832e1@gmail.com>
In-Reply-To: <8f56b4d6264b8e5a85ba73bc8ac541efa066c8a6.1723791831.git.ps@pks.im>

Hi Patrick

On 16/08/2024 08:04, Patrick Steinhardt wrote:
> diff --git a/t/unit-tests/unit-test.c b/t/unit-tests/unit-test.c
> index 32a81299e9..82b7635e6a 100644
> --- a/t/unit-tests/unit-test.c
> +++ b/t/unit-tests/unit-test.c
> @@ -6,10 +6,9 @@ int cmd_main(int argc, const char **argv)
>   	int ret;
>   
>   	/* Append the "-t" flag such that the tests generate TAP output. */
> -	ALLOC_ARRAY(argv_copy, argc + 2);
> +	ALLOC_ARRAY(argv_copy, argc + 1);
>   	COPY_ARRAY(argv_copy, argv, argc);
>   	argv_copy[argc++] = "-t";
> -	argv_copy[argc] = NULL;

I'm confused by this - it looks like it belongs in the previous patch 
but why are we deleting the line that adds the terminating NULL to argv 
in the first place?

Thanks

Phillip