From: Brian Gernhardt <benji@silverinsanity.com>
Date: Tue, 03 Feb 2009 15:07:03 GMT
Subject: Re: [PATCH] t3411: Fix test 1 for case-insensitive file systems
Message-ID: <1E104E1B-BFCC-4CFC-9D53-CE89299C9600@silverinsanity.com>
In-Reply-To: <673CE949-5DF9-4970-A739-AA09FCD26D24@silverinsanity.com>

This change appears to have been forgotten, but does fix the problems  
I was having.  Junio, can this make it into the official repo instead  
of floating around in my local?  I'd send in a patch, but it was your  
code and I don't want to take credit for it.

~~ Brian

On Jan 29, 2009, at 2:10 PM, Brian Gernhardt wrote:

>
> On Jan 29, 2009, at 12:19 PM, Junio C Hamano wrote:
>
>> If we really wanted to care about case-folding file systems,  
>> shouldn't we
>> make test_commit shell function a bit more than the downcasing?   
>> How about
>> this patch instead?
>
> That's a good point.  Always good to prevent future issues.
>
>> test_commit () {
>> -	file=${2:-$(echo "$1" | tr 'A-Z' 'a-z')}
>> +	file=${2:-$(echo "$1" | tr 'A-Z' 'a-z').t}
>> 	echo "${3-$1}" > "$file" &&
>> 	git add "$file" &&
>> 	test_tick &&
>
> Added this and ran through the tests.  Works for me. :-D
>
> Tested-by: Brian Gernhardt <benji@silverinsanity.com> (HFS+ on Mac  
> OS 10.5.6)