From: Väinö Järvelä Date: Fri, 24 Aug 2007 06:28:51 GMT Subject: Re: [PATCH 1/2] Add "--only-untracked" flag to status commands. Message-ID: <1C01FFED-1C80-4C1F-A73D-2529B5B81F7E@pp.inet.fi> In-Reply-To: On Aug 23, 2007, at 23:50, Matthieu Moy wrote: > Väinö Järvelä writes: > >> Subject: Re: [PATCH 1/2] Add "--only-untracked" flag to status >> commands. > ^^ > > I suppose you meant --only-tracked. Yes, a stupid typo. It should be --only-tracked. >> static const char runstatus_usage[] = >> -"git-runstatus [--color|--nocolor] [--amend] [--verbose] [-- >> untracked]"; >> +"git-runstatus [--color|--nocolor] [--amend] [--verbose] >> [--untracked]" "[--only-tracked]"; > ^^^ > > The compiler will concatenate the strings, but won't add a space. That > results in "... [--untracked][--only-tracked]". Should have checked it more properly, sorry about that. > > Otherwise, the patch sounds fine to me. Not /terribly/ usefull, but > why not. This is something that has come up many times on our project, there might be a lot of temporary files that are used inside the project tree, to test the code, and the user just wants to see the modifications to tracked files without using a pager. One could use gitignore, but in our case, it would be hard to create a gitignore which would ignore all of the test files, and none of the actual project files, so it's quite convenient to use --only-tracked. A better behavior might be to test outside of the project tree. > > -- > Matthieu -- Väinö