From: Ben Knoble Date: Wed, 16 Sep 2026 17:53:03 GMT Subject: Re: [PATCH v5 3/3] push: --force-if-includes should allow fast-forward Message-ID: <1BCA7C21-AC51-4706-9F2B-27BF2E94A13B@gmail.com> In-Reply-To: > > Le 16 sept. 2026 à 11:52, Tyler Cipriani a écrit : > > On Wed, Sep 16, 2026 at 6:29 AM D. Ben Knoble wrote: >> >> Hi Tyler, [snip] >> Perhaps we want to >> make "deferred_reject_reason" more clearly indicate that to save >> future readers headache if they insert code around here? I'm not sure >> the best way to do that, though, so maybe blaming to the log message >> will suffice. > > I tried to indicate the rationale with comments, but I'm open to > changing the variable name, too. I felt that the "deferred" in the > name captured it, but the name also feels a little broad vs. what it > does. > > Before I take a stab at a reroll for commit message updates + variable > names, I'd like to gather more feedback on the direction and > implementation of this series. Yes, I think that’s a good idea :) > Thanks you for your thoughtful comments, Ben! I've appreciated how > you've helped me think about this feature. You’re quite welcome, thank you!