From: Jörn Hees <dev@joernhees.de>
Date: Fri, 26 Jul 2013 12:17:08 GMT
Subject: Re: [PATCH v3] remotes-hg: bugfix for fetching non local remotes
Message-ID: <1A5ABD76-D3D9-400E-AC8F-26C0DEF43723@joernhees.de>
In-Reply-To: <CALWbr2x9fG=diZPN-Wkq+-7bstoVmN_pnXN0EPi=4MZQVRuYXg@mail.gmail.com>

On 25 Jul 2013, at 23:10, Antoine Pelisse <apelisse@gmail.com> wrote:

> On Thu, Jul 25, 2013 at 10:40 PM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
>> That's true. Maybe something like:
>> 
>> for x in repos:
>>  local_hg = os.path.join(shared_path, x, 'clone', '.hg')
>>  if os.path.exists(local_hg):
>>    shutil.copytree(local_hg, hg_path)
>>    break
> 
> I think that would work

yupp, might work, but holding you liable to the same optimality restriction you imposed on me before:
This will still refetch the whole repo once if it was cloned from a local hg repo first (they don't have a clone subdir).
Shouldn't we then also go through the additional effort and copy the .hg dir from local remotes when a "remote remote" is added and there's no other remote remote?

j