From: Li Chen <me@linux.beauty>
Date: Mon, 02 Mar 2026 15:00:26 GMT
Subject: Re: [PATCH v7 1/5] interpret-trailers: factor trailer rewriting
Message-ID: <19caf109a99.6c639fbf1370819.2681969272338930783@linux.beauty>
In-Reply-To: <56b1b6b6-94c2-4a2f-b473-9b4d09d6f52e@gmail.com>

Hi Phillip,

 ---- On Mon, 02 Mar 2026 22:56:04 +0800  Phillip Wood <phillip.wood123@gmail.com> wrote --- 
 > Hi Li
 > 
 > On 24/02/2026 07:05, Li Chen wrote:
 > > Extract the trailer rewriting logic into a helper that appends to an
 > > output strbuf.
 > > 
 > > Update interpret_trailers() to handle file I/O only: read input once,
 > > call the helper, and write the buffered result.
 > > 
 > > This separation makes it easier to move the helper into trailer.c in the
 > > next commit.
 > 
 > This is still missing my sign off c.f. 
 > https://lore.kernel.org/f5152523-f7ff-4dee-a685-fb0b74cd6a56@gmail.com
 > 
 > > Signed-off-by: Li Chen <me@linux.beauty>
 > > ---
 > > v7:
 > > Use strbuf_write() when emitting buffered output.
 > 
 > Also renamed "sb" to "input"
 > 
 > Apart from the missing sign off this all looks good.
 
I sincerely apologize for that! I did check it during development, but somehow lost
track in the end. I will definitely include your sign-off in the next version!

Regards,
Li