From: Li Chen <me@linux.beauty>
Date: Tue, 21 Oct 2025 10:01:54 GMT
Subject: Re: [PATCH v3 1/2] trailer: append trailers in-process and drop the fork to `interpret-trailers`
Message-ID: <19a0637d7c6.56c0ee933118113.6864199134170276242@linux.beauty>
In-Reply-To: <d4c9f082-52be-48d9-b817-fcb8a72e1bd7@gmail.com>

Hi Phillip,

 > >       new_trailers_clear(&trailers);
 > > diff --git a/trailer.c b/trailer.c
 > > index 310cf582dc..03814443c3 100644
 > > --- a/trailer.c
 > > +++ b/trailer.c
 > > @@ -1224,14 +1224,121 @@ void trailer_iterator_release(struct trailer_iterator *iter)
 > >       strbuf_release(&iter->key);
 > >   }
 > >   
 > > -int amend_file_with_trailers(const char *path, const struct strvec *trailer_args)
 > > +static int amend_strbuf_with_trailers(struct strbuf *buf,
 > > +                   const struct strvec *trailer_args)
 > 
 > Function argument declarations should be aligned
 
My editor uses a 4-space tab width, but the project view displays tabs as 8 spaces wide.
This discrepancy caused the same errors in v4, which I plan to correct with clang-format in v5.

Regards,

Li​