From: Li Chen <me@linux.beauty>
Date: Wed, 15 Oct 2025 13:58:59 GMT
Subject: Re: [PATCH v4 17/29] tests: t3440: create expect files at point of use
Message-ID: <199e82ac06b.22809060320824.5985600477588171363@linux.beauty>
In-Reply-To: <4eb06e60-e088-462b-9f1b-ca800af39b94@app.fastmail.com>

Hi Kristoffer,

Thanks for the review suggestions! I'll address them in the next version.

 ---- On Wed, 15 Oct 2025 04:41:33 +0800  Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com> wrote --- 
 > Now you start to change the test suite/file that you created for this
 > series.  There shouldn’t be a need to do a test file-only patch/commit
 > for a fresh series.
 > 
 > I saw in one of your patches that you removed `--keep-empty` from a test
 > because “that is the default”.  I also saw Phillip’s comment somewhere
 > that said the same thing.
 > 
 > The goal with maturing series is not to add patches on top in each round
 > (if that’s what you are doing).  It is to recreate them as if the series
 > was perfectly written to begin with; if one patch introduces
 > `--trailers` and a test file, then there should be no need with
 > follow-up patches that improve the test file style, refactors it, and
 > so on.

Thanks for the tip. I split the changes into separate commits to ease review,
 as Phillip suggested in https://lore.kernel.org/git/d4c9f082-52be-48d9-b817-fcb8a72e1bd7@gmail.com/.

It seems I may have overdone it? If so, I'll try for a better balance in the next version.

Li​