From: Ramsay Jones Date: Wed, 02 Jul 2025 22:37:23 GMT Subject: Re: Bug: build is broken on FreeBSD if libsysinfo is installed Message-ID: <1993f24d-4433-427a-a834-360f6a9a963a@ramsayjones.plus.com> In-Reply-To: <39e370f3-5113-4feb-8a19-2cbdba6c17ce@FreeBSD.org> On 02/07/2025 20:48, Renato Botelho wrote: > On 02/07/25 14:08, Junio C Hamano wrote: >> Renato Botelho writes: >> >>>> I very quickly knocked up a patch to do the last option above (I >>>> moved >>>> the setting of HAVE_SYSINFO down the file rather that HAVE_BSD_SYSCTL >>>> up. I guess it doesn't matter, but I gave it *no* thought!). >>>> The patch is below. (I didn't write a commit message ;) ). >>>> Does this work for you? >>> >>> Your patch works just fine for FreeBSD.  I tried it with libsysinfo >>> installed and it just ignored it, as expected. >>> >>> I didn't test meson build since FreeBSD ports is based on autotools yet. >>> >>> BTW, should I start moving the port to meson?  Is it the default build >>> method now?  Is there a plan to remove autotools? >>> >>> Thank you! >> >> So we have a bit of loose end that needs a finishing touch, but >> otherwise we are good to go? > From my side, yes. OK, I will write a commit message and submit the patch to the list some time soon (I'm a little busy atm, sorry!). ATB, Ramsay Jones