From: Adrian Ratiu <adrian.ratiu@collabora.com>
Date: Sun, 17 Aug 2025 13:01:04 GMT
Subject: Re: [PATCH 0/9] Encode submodule gitdir names to avoid conflicts
Message-ID: <198b81e845f.3d0b85c81892243.3876804306135930880@collabora.com>
In-Reply-To: <20250816213642.3517822-1-adrian.ratiu@collabora.com>

 ---- On Sun, 17 Aug 2025 00:36:33 +0300  Adrian Ratiu <adrian.ratiu@collabora.com> wrote --- 
 > Hello,
 > 
 > This is a continuation of work done back in 2018 [1], so a big thank you to
 > everyone who participated in the initial thread, especially Brandon on whose
 > code this is partially based upon. Hope you are still around and doing well. :)
 > 
 > It's mostly a rewrite from scratch addressig open feedback. I decided to
 > iterate upen Brandon's url-encoding design instead of pursuing alternatives
 > like a custom encoding, name hashing or round-trip encoding/decoding using
 > an in-memory git mapping (we'd still have to encode/hash the paths to avoid
 > colflicts so IIUC this last one is more complicated for little gain).
 > 
 > I tried to organize and explain the commits in a logical way which is also
 > easy to review, keeping the encoding parts, new tests, code moving around
 > and path update churn as clearly separated as possible.
 > 
 > This is based on master and I've merged and succesfully run all tests in
 > both the next and seen branches.

I also ran the GitHub CI pipeline and noticed there are failures on Win + Mac.

I will address those in v2.

In the meantime I'll leave v1 for a while on the ML to gather more feedback.