From: Li Chen <me@linux.beauty>
Date: Mon, 04 Aug 2025 01:44:45 GMT
Subject: Re: [PATCH v3 0/2] rebase: support --trailer
Message-ID: <19872c0a7f9.4f0ce123219344.1150677041521426116@linux.beauty>
In-Reply-To: <xmqq8qk0fjma.fsf@gitster.g>

Hi Junio,

 ---- On Mon, 04 Aug 2025 00:35:57 +0800  Junio C Hamano <gitster@pobox.com> wrote --- 
 > Li Chen <me@linux.beauty> writes:
 > 
 > > From: Li Chen <chenl311@chinatelecom.cn>
 > >
 > > This two-patch series teaches git rebase a new
 > > --trailer <text> option and, as a prerequisite, moves all trailer
 > > handling out of the external interpret-trailers helper and into the
 > > builtin code path, as suggested by Phillip Wood.
 > >
 > > Patch 1 switches trailer.c to an in-memory implementation
 > > (amend_strbuf_with_trailers()). It removes every fork/exec.
 > >
 > > Patch 2 builds on that helper to implement
 > > git rebase --trailer.
 > 
 > Try running "git show --check" on this commit.  My attempt found a
 > handful of whitespace breakages ("indent with spaces.").
 > 
 > Thanks.
 > 
 > 

That's a great tool, I wasn't aware of that command, and I will fix them in
Next version. Thanks, Junio.

Regards,
Li