From: Frank Li Date: Fri, 05 Mar 2010 02:31:18 GMT Subject: Re: [PATCH v5-j6t 2/3] git-core: Support retrieving passwords with GIT_ASKPASS Message-ID: <1976ea661003041831n2573bda2xd0f528e03a1444de@mail.gmail.com> In-Reply-To: <201003042059.51516.j6t@kdbg.org> > >  I changed the code to make struct strbuf buffer itself static and fixed >  the error message. I removed the comment about the memory leak again >  because now the buffer is conceptually static even though behind the >  scenes it points to allocated memory. > >  Frank, I did not test it beyond the test suite. Please test and say >  no or go. > Thanks. I test it. It work rightly with prompted password appliction(ssh-askpass). best regards Frank Li