From: Frank Li Date: Fri, 26 Feb 2010 02:17:44 GMT Subject: Re: [PATCH v2 2/3] git-core: Support retrieving passwords with GIT_ASKPASS Message-ID: <1976ea661002251817v12f04314vc32fe7924f31c070@mail.gmail.com> In-Reply-To: <20100226005020.GR12429@genesis.frugalware.org> > According to Documentation/CodingGuidelines, this would be: > > >                for (i = 0; i < buffer.len; i++) >                        if (buffer.buf[i] == '\n' || buffer.buf[i] == '\r') { >                                buffer.buf[i] = '\0'; >                                buffer.len = i; >                        } >                return strbuf_detach(&buffer, NULL); > >        } else >                return getpass(prompt); > Okay, I will change it.