From: Frank Li <lznuaa@gmail.com>
Date: Tue, 18 Aug 2009 02:15:51 GMT
Subject: Re: [PATCH 09/11] Add MSVC porting header files.
Message-ID: <1976ea660908171915v62fb6c40j17f750cac9836433@mail.gmail.com>
In-Reply-To: <alpine.DEB.1.00.0908171902300.4991@intel-tinevez-2-302>


>> Add unix head file, dirent.h, unistd.h  and time.h
>
> These are copied from somewhere.  From where?  What is the license?

It comes from msys,  which used to build msysgit.

>> Add MSVC special porting head file msvc.h and msvc.c.
>
> This is added by you.  Logically, that should be a separate patch.

Okay I will split.

>> +#define NO_MEMMEM
>> +#define NO_C99_FORMAT
>> +#define NO_STRTOUMAX
>> +#define NO_MKDTEMP
>> +#define NO_MKSTEMPS
>> +
>> +#define RUNTIME_PREFIX
>> +#define NO_ST_BLOCKS_IN_STRUCT_STAT
>> +#define NO_NSEC
>> +#define USE_WIN32_MMAP
>> +#define USE_NED_ALLOCATOR
>> +
>> +#define NO_REGEX
>> +
>> +#define NO_SYS_SELECT_H
>> +#define NO_PTHEADS
>> +#define HAVE_STRING_H 1
>> +#define STDC_HEADERS
>> +#define NO_ICONV
>
> These would normally be defined in the Makefile.  You might want to state
> that in a comment.
>
> Or maybe move the definitions (along with vsnprintf) to the .vcproj file,
> which is the logical pendant of the Makefile?

I really want to in .vcproj.  but the same context needs to copy
DEBUG\RELEASE 32\64bit, libgit.vcproj and git.vcproj. 8 place needs
copy.  To avoid copy in vcproj file, I move it hear.