From: Frank Li <lznuaa@gmail.com>
Date: Tue, 18 Aug 2009 02:02:17 GMT
Subject: Re: [PATCH 07/11] Add O_BINARY flag to open flag at mingw.c
Message-ID: <1976ea660908171902ubf04991x7d6890d4d9accd9a@mail.gmail.com>
In-Reply-To: <alpine.DEB.1.00.0908171856290.4991@intel-tinevez-2-302>


> How about this instead?
>
>        mingw.c: Use the O_BINARY flag to open files
>
>        On Windows, non-text files must be opened using the O_BINARY flag.
>        MinGW does this for us automatically, but Microsoft Visual C++
>        does not.
>
>        Also, Johannes said that this would be a nice cleanup.
>

Okay, Do you need me change commit comments to resubmit patch?

> BTW what about fopen()?

I never found problem at fopen, I will double check it.

>
> Patch is obviously good.
>
> Ciao,
> Dscho
>