From: Frank Li <lznuaa@gmail.com>
Date: Tue, 18 Aug 2009 01:51:34 GMT
Subject: Re: [PATCH 08/11] Place __stdcall to correct position.
Message-ID: <1976ea660908171851n16b8b56j378ace9ecf0ce272@mail.gmail.com>
In-Reply-To: <alpine.DEB.1.00.0908171859060.4991@intel-tinevez-2-302>

> How about "... to the correct ..." and "MSVC requires _stdcall to be
> between return value..." and "All Win32 API functions are declared with
> the WINAPI attribute."?

WINAPI always like

BOOL WINAPI function_name(xxx);
It compile fail if WINAPI BOOL function_name(xxx);

>>  #if defined(__MINGW32__) || defined(_MSC_VER)
>> -static __stdcall unsigned run_thread(void *data)
>> +static unsigned __stdcall run_thread(void *data)
>>  {
>>       struct async *async = data;
>>       return async->proc(async->fd_for_proc, async->data);
>>  }
>> -#endif
>> +#endif /* __MINGW32__ || _MSC_VER */
>
> I do not think this is necessary.  There are only 5 lines wrapped into
> those #ifdef guards, the developer should be able to see that far.
>
Do you means remove /* __MINGW32__ || _MSC_VER */?