From: Frank Li Date: Tue, 23 Jun 2009 01:26:51 GMT Subject: Re: git-mailsplit and TortoiseGit bugs Message-ID: <1976ea660906221826lfc074c2x6231dcae16535a9c@mail.gmail.com> In-Reply-To: <5b31733c0906221446m1a82b39fkd5d25ea413697138@mail.gmail.com> Do you means I should remove "boundary=WC_MAIL_PaRt_BoUnDaRy_05151998" when send patch without attachment? Tortoisegit bug report: http://code.google.com/p/tortoisegit/issues/list best regards Frank Li 2009/6/23 Filip Navara : > On Mon, Jun 22, 2009 at 10:29 PM, Jeff King wrote: >> On Mon, Jun 22, 2009 at 07:53:51PM +0200, Filip Navara wrote: >> >>> I'd like to report a bug. There's an incompatibility between the way >>> TortoiseGit sends patches by e-mail and their handling by >>> git-mailsplit. The mail sent by TortoiseGit specifies the Content-Type >>> header as "Content-Type: text/plain; >>> boundary=WC_MAIL_PaRt_BoUnDaRy_05151998". git-mailsplit then >>> misinterprets it and treats it as empty patch. While TortoiseGit >>> should not be sending the boundary parameter, it is perfectly valid >>> e-mail according to RFC 5322 and MIME RFCs. The "boundary" parameter >>> should be ignored for anything but "multipart" Content-Types. >> >> That seems like a bug in TortoiseGit, and I don't know if it is worth >> git trying to work around problems in something that is not even close >> to a 1.0 version. >> >> Still, it is good to be liberal in what we accept. So maybe the patch >> below is worth applying (I assume from your description it will fix the >> problem you are having, but I didn't actually test it with TortoiseGit; >> please confirm that it helps). > > Yes, this patch helps. While TortoiseGit shouldn't send the parameter > in the first place it's still prefectly valid e-mail that should be > accepted. Of course I will report it in the TortoiseGit issue tracker > for fixing. > > Thanks, > Filip Navara > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at  http://vger.kernel.org/majordomo-info.html >