From: Eli Barzilay <eli@barzilay.org>
Date: Fri, 14 May 2010 05:05:10 GMT
Subject: Re: Re: git log -M -- filename is not working?
Message-ID: <19436.55814.552536.42519@winooski.ccs.neu.edu>
In-Reply-To: <20100514045522.GE6075@coredump.intra.peff.net>

On May 14, Jeff King wrote:
> [...]

(I didn't get most of that...)

> The only "downside" is that it means --follow actually impacts the diff
> generation by implying --find-copies-harder. And I put downside in
> quotes because it is probably not a big deal. We have already spent the
> CPU time to find the answer, so it is silly not to show it. I can't
> imagine why somebody would want --follow, but would _not_ want rename
> detection in the resulting diff.

...but this seems very reasonable.  (In fact, if --follow implies
finding copies and renames, and if it's doing that for diff too, then
it's exactly what I originally wanted.)


> Bo's version of the patch does that optimization. When I clean up the
> patch (probably sometime next week), I'll take those changes.

Thanks!

-- 
          ((lambda (x) (x x)) (lambda (x) (x x)))          Eli Barzilay:
                    http://barzilay.org/                   Maze is Life!