From: Derrick Stolee Date: Tue, 05 Nov 2019 17:38:10 GMT Subject: Re: [PATCH 1/1] commit-graph: use start_delayed_progress() Message-ID: <18dde6fe-9072-2069-8063-f1cfcdee3f38@gmail.com> In-Reply-To: <174c05bf29bbd92342aa45132592c348f988cf0b.1572969955.git.gitgitgadget@gmail.com> On 11/5/2019 11:05 AM, Derrick Stolee via GitGitGadget wrote: > From: Derrick Stolee > > When writing a commit-graph, we show progress along several commit > walks. When we use start_delayed_progress(), the progress line will > only appear if that step takes a decent amount of time. > > However, one place was missed: computing generation numbers. This is > normally a very fast operation as all commits have been parsed in a > previous step. But, this is showing up for all users no matter how few > commits are being added. For course, now that we do not force at least one progress line to show up, the tests that check the `--progress` option (or `--no-quiet` for GC) will fail with this patch. v2 coming soon. -Stolee