From: Brian Gernhardt <brian@gernhardtsoftware.com>
Date: Thu, 30 Sep 2010 14:30:31 GMT
Subject: Re: [PATCH 00/16] git-send-email cleanups
Message-ID: <18E0A903-D625-4C7A-A575-AC5C5EF448C9@gernhardtsoftware.com>
In-Reply-To: <1285854189-10240-1-git-send-email-avarab@gmail.com>


On Sep 30, 2010, at 9:42 AM, Ævar Arnfjörð Bjarmason wrote:

>  send-email: get_patch_subject doesn't need a prototype
>  send-email: file_declares_8bit_cte doesn't need a prototype
>  send-email: unique_email_list doesn't need a prototype
>  send-email: cleanup_compose_files doesn't need a prototype

None of these subroutines strictly need the prototype, but it does allow Perl to warn us if we send incorrect arguments.  Why remove them?  Are they causing problems somewhere?

~~ Brian