From: Paul Mackerras Date: Tue, 21 Oct 2008 11:35:55 GMT Subject: Re: [PATCH 1/7] gitk: Enhance UI popup and accelerator handling. Message-ID: <18685.48795.892869.474750@cargo.ozlabs.ibm.com> In-Reply-To: <1223449540-20457-2-git-send-email-angavrilov@gmail.com> Alexander Gavrilov writes: > - Popups are supposed to be marked transient, otherwise > the WM creates them in strange places. Besides, at > least under kwin, transients are automatically kept > above their parent. > - Accelerators for menu items should be listed directly > on the items, to make them more discoverable. > - Some more accelerators are added, e.g. F4 for Edit View. > - Finally, dialogs can now be accepted or dismissed using > the Return and Escape keys. Could you rebase this and split it into 3 patches, one each for the transient popups, accelerators, and return/escape key bindings? Thanks, Paul.