From: Paul Mackerras <paulus@samba.org>
Date: Fri, 10 Oct 2008 11:21:16 GMT
Subject: Re: [PATCH (GITK) v2 3/4] gitk: Support filenames in the locale encoding.
Message-ID: <18671.15020.13951.943822@cargo.ozlabs.ibm.com>
In-Reply-To: <1222772422-28020-4-git-send-email-angavrilov@gmail.com>

Alexander Gavrilov writes:

> The previous patch changed the encoding used for
> reading diffs to binary, which broke non-ASCII filename
> support. This one fixes the breakage, together with some
> existing bugs related to filename encoding.

Sounds like this patch should be combined with the previous one.

> @@ -6250,11 +6250,12 @@ proc gettreeline {gtf id} {
>  	    set line [string range $line 0 [expr {$i-1}]]
>  	    if {$diffids ne $nullid2 && [lindex $line 1] ne "blob"} continue
>  	    set sha1 [lindex $line 2]
> -	    if {[string index $fname 0] eq "\""} {
> -		set fname [lindex $fname 0]
> -	    }
>  	    lappend treeidlist($id) $sha1
>  	}
> +	if {[string index $fname 0] eq "\""} {
> +	    set fname [lindex $fname 0]
> +	}

Concerning this part of the change, do we know whether git ls-files
will quote filenames containing special characters or not?

Paul.