From: Paul Mackerras Date: Thu, 09 Oct 2008 11:02:46 GMT Subject: Re: [PATCH 1/7] gitk: Enhance UI popup and accelerator handling. Message-ID: <18669.58582.403341.404978@cargo.ozlabs.ibm.com> In-Reply-To: Alexander Gavrilov writes: > On Thu, Oct 9, 2008 at 4:27 AM, Paul Mackerras wrote: > >> + catch { bind . {newview 0} } > > > > What is this key, or why is this line needed? > > It is a workaround for an apparent bug in interaction between Tk and > XKB on some systems. > XKB configuration files bind those symbols to Ctrl-Alt-F* > combinations, but Tk's keyboard > handiling code sees them when Shift-F* is pressed. I'll be glad to > find a better fix, but that's > all I could do for now. OK, that information should go in the patch description. > > You need to change the error returns in domktag to say "return 0", > > otherwise this will give a "can't use empty string as operand of "!"" > > Tcl error. > > I did not know this. I'm not that familiar with Tcl... Then I am amazed at how much you have been able to accomplish... There's a lot of information available in the Tcl/Tk man pages. On Debian or Ubuntu, you need the tcl8.5-doc and tk8.5-doc packages installed. Then you can do e.g. "man 3tcl Tcl" to get a summary of the Tcl language syntax, etc. BTW, I haven't forgotten about your encoding support patches. The last month has been occupied with travelling for Kernel Summit and the Linux Plumbers Conference, followed by a vacation, and then catching up with work that has piled up, so I haven't had much time to spare for gitk hacking. Paul.