From: Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>
Date: Fri, 24 Jun 2016 11:49:24 GMT
Subject: Re: [PATCH v3 4/4] archive-tar: drop return value
Message-ID: <1865881092.716701.1466768964884.JavaMail.zimbra@ensimag.grenoble-inp.fr>
In-Reply-To: <20160623232158.GD3668@sigill.intra.peff.net>

Hi Peff,

Jeff King <peff@peff.net> writes:
> @@ -413,7 +411,7 @@ static int write_tar_archive(const struct archiver *ar,
>  {
>          int err = 0;
>  
> -        err = write_global_extended_header(args);
> +        write_global_extended_header(args);
>          if (!err)
>                  err = write_archive_entries(args, write_tar_entry);

If we drop the error code from 'write_global_extended_header' then the
above 'if (!err)' becomes useless (always evaluates to 'true' since
'err' is set to '0').

>          if (!err)

Thanks,
Rémi