From: Michael Haggerty Date: Wed, 27 Apr 2016 16:57:33 GMT Subject: [PATCH 16/29] ref_transaction_commit(): correctly report close_ref() failure Message-ID: <18490be7195bac46a955b385b6848a2383417188.1461768690.git.mhagger@alum.mit.edu> In-Reply-To: Signed-off-by: Michael Haggerty --- close() rarely fails, but it is possible. refs/files-backend.c | 1 + 1 file changed, 1 insertion(+) diff --git a/refs/files-backend.c b/refs/files-backend.c index 8fcbd7d..e86e3de 100644 --- a/refs/files-backend.c +++ b/refs/files-backend.c @@ -3144,6 +3144,7 @@ int ref_transaction_commit(struct ref_transaction *transaction, if (close_ref(update->lock)) { strbuf_addf(err, "couldn't close '%s.lock'", update->refname); + ret = TRANSACTION_GENERIC_ERROR; goto cleanup; } } -- 2.8.1