From: Paul Mackerras <paulus@samba.org>
Date: Mon, 07 Jan 2008 21:35:03 GMT
Subject: Re: gitk dev branch: F5 gives error after commit
Message-ID: <18306.39687.333117.276550@cargo.ozlabs.ibm.com>
In-Reply-To: <478258B6.20006@viscovery.net>

Johannes Sixt writes:

> I use the dev branch of gitk (on Windows), commit 476ca63 (gitk: Index
> [fnvr]highlights by id rather than row).
> 
> 1. Start it with:
> 
>     gitk --all -300
> 
> 2. Make a commit.
> 3. Hit F5. Here I see the error message:
> 
>    Error reading commits:
>    fatal: bad revision '^-300'

This happens because I naively thought 'git rev-parse --revs-only'
would only give me SHA1 IDs.  But in any case gitk (on the dev branch)
doesn't really do anything much to handle commit selection flags that
can't be turned into SHA1 IDs (possibly negated).

Thanks for testing.  I'll fix it.

Paul.