From: Jeff Hostetler <git@jeffhostetler.com>
Date: Tue, 29 Jan 2019 22:08:09 GMT
Subject: Re: [PATCH v2 14/14] trace2: t/helper/test-trace2, t0210.sh, t0211.sh, t0212.sh
Message-ID: <180fc774-d080-0ff4-72a5-c54dd77bc59b@jeffhostetler.com>
In-Reply-To: <xmqqd0oga0b6.fsf@gitster-ct.c.googlers.com>



On 1/28/2019 5:23 PM, Junio C Hamano wrote:
> "Jeff Hostetler via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> +test_expect_success 'perf stream, return code 0' '
>> +	test_when_finished "rm trace.perf actual expect" &&
>> +	GIT_TR2_PERF="$(pwd)/trace.perf" && export GIT_TR2_PERF &&
>> +	$TT trace2 001return 0 &&
>> +	unset GIT_TR2_PERF &&
> 
> Do not do this.  Stoppage in any different one of these steps would
> leave the state of the process in different state and affects later
> tests (e.g. TR2_PERF may or may not be exported).
> 
> Is $TT always "test-tool" (i.e. the binary, not a shell function)?
> If so, consider using a single-short export, i.e.
> 
> 	GIT_TR2_PERF="..." test-tool trace2 001return 0 &&
> 

I'll redo the fix for this to use the inline form
and send a new version tomorrow.

Thanks
Jeff