From: Brian Lyles <brianmlyles@gmail.com>
Date: Thu, 05 Sep 2024 18:24:14 GMT
Subject: Re: [PATCH] interpret-trailers: handle message without trailing newline
Message-ID: <17f26c45e0877048.9cb17c440a994cc2.6350cf4ad3b0703a@epic110867>
In-Reply-To: <20240905173445.1677704-1-brianmlyles@gmail.com>


On 05/09/2024 12:34, Brian Lyles wrote:
> +	/*
> +	 * True if the last character before the location pointed to be
> +	 * trailer_block_start is a newline character.
> +	 */
> +	int message_without_trailing_newline_before_trailer;

I just noticed that this comment is incorrect, reflecting an older
local version of this patch. In v2 this will be:

    True if there is a message before the trailer block and it does not
	end with a trailing newline character.


> +/*
> + * Return 1 if the trailer block had a newline character
> + */
> +int message_without_trailing_newline_before_trailer_block(struct trailer_info *);

Same thing here. In v2 this will be:

	Return true if there is a message before the trailer block and it
	does not end with a trailing newline character.

I will wait to send out a v2 until later tonight to avoid spamming
folks, and give others a chance to provide feedback.

-- 
Thank you,
Brian Lyles