From: Brian Lyles <brianmlyles@gmail.com>
Date: Sat, 16 Mar 2024 03:07:45 GMT
Subject: Re: [PATCH v3 4/7] sequencer: treat error reading HEAD as unborn branch
Message-ID: <17bd1fdc7357bd91.70b1dd9aae081c6e.203dcd72f6563036@zivdesk>
In-Reply-To: <87155d50-40b8-4394-99f3-5194d7da785a@gmail.com>

Hi Phillip

On Wed, Mar 13, 2024 at 10:10 AM <phillip.wood123@gmail.com> wrote:

> Hi Brian
> 
> On 10/03/2024 18:42, Brian Lyles wrote:
>> - Avoid using `--quiet` in the `git diff` call to make debugging easier
>>    in the event of a failure
> 
> Sorry, I forgot when I was reviewing v2 that we need to replace --quiet 
> with --exit-code otherwise the diff will never fail. Apart from that I 
> don't have anything to add to Junio's comments on this patch.

Ah, of course -- thank you for catching that. I'll include that in v4.

-- 
Thank you,
Brian Lyles