From: Philip Oakley <philipoakley@iee.org>
Date: Thu, 05 May 2016 20:48:40 GMT
Subject: /* compiler workaround */ - what was the issue?
Message-ID: <17E04501C9474282B87758C7998A1F5B@PhilipOakley>
In-Reply-To: <AA5B2B1715BAF7438221293187A417A7BDE9D11D@desmdswms002.des.grplnk.net>

Duy,

In 
https://github.com/git-for-windows/git/commit/b3c96fb158f05152336f167076f5d81d23c3a5e5
(split-index: strip pathname of on-disk replaced entries, 13 Jun 2014) 
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>  you have

read-cache.c#L1790 (in that commit, now ~L1873)

    int saved_namelen = saved_namelen; /* compiler workaround */

Which then becomes an MSVC compile warning C4700: uninitialized local 
variable.

I'm wondering what was the compiler workaround being referred to? i.e. why 
does it need that tweak? There's no mention of the reason in the commit 
message.

There are a few other occurences of this same initialisation issue, so I was 
wondering if it's still neded? Or should I just get MSVC to ignore it, which 
may hide other issues..

--
Philip