From: Juergen Ruehle <j.ruehle@bmiag.de>
Date: Wed, 10 Jan 2007 20:14:26 GMT
Subject: Re: [PATCH] Provide better feedback for the untracked only case in status output
Message-ID: <17829.18722.194000.927872@lapjr.intranet.kiel.bmiag.de>
In-Reply-To: <1168452977.19643.57.camel@ibook.zvpunry.de>

Michael Loeffler writes:
 > hi,
 > 
 > Am Mittwoch, den 10.01.2007, 08:08 +0100 schrieb Juergen Ruehle:
 > ...
 > > @@ -311,12 +312,14 @@ void wt_status_print(struct wt_status *s)
 > ...
 > > +		else if (s->is_initial)
 > > +			printf("nothing to commit (working directory is empty)\n");
 > Shouldn't the user know that there is nothing in his working directory?

:-)

Well this is the state directly after git-init, e.g. the very first
contact with git. Perhaps we should write:

nothing to commit (create files in the working directory and use git add)

 > > +		else
 > > +			printf("nothing to commit (working directory matches HEAD)\n");
 > How about s/matches HEAD/clean/

I like that.

 > There is another thing:
 > # Changed but not added:
 > #   (use "git add <file>..." to incrementally add content to commit)
 > #
 > #       deleted:    blah
 > 
 > How about adding some more hints (e.g.: git rm --cached <file>)
 > depending on the diff_queue in wt_status_print_changed_cb()?

Yes, there's always one more case to consider:-)