From: Juergen Ruehle Date: Sat, 06 Jan 2007 13:33:32 GMT Subject: Re: [PATCH 1/2] Suggest use of "git add file1 file2" when there is nothing to commit. Message-ID: <17823.42284.620000.476920@lapjr.intranet.kiel.bmiag.de> In-Reply-To: <7vodpcae9s.fsf@assigned-by-dhcp.cox.net> Junio C Hamano writes: > Junio C Hamano writes: > > > Michael Loeffler writes: > > > >> Am Freitag, den 15.12.2006, 21:53 -0500 schrieb Shawn O. Pearce: > >> ... > >>> + printf("%s (%s)\n", > >>> + s->amend ? "# No changes" : "nothing to commit", > >>> + use_add_msg); > >>> } > >> I don't like the new 'nothing to commit (use "git add ... message")' > >> message. I use git status very often to see if there is something to > >> commit, but now there is always this annoying "use git add ..." message. > > > > I tend to not like _ANY_ change at all, but I've learned to wait > > and see if I get used to it when I see something that annoys me > > initially, to see if the annoyance is because what it does is > > truly wrong or it is because what it does is merely different > > from what I am used to. > > > > So I've been trying it out myself as one of the guinea pigs on > > this one as well. > > > > So far, my judgement is that this is of the better kind; it is > > easy to get used to, and once you get used to it, it is easily > > ignorable. > > How about doing this? > > -- >8 -- > git-status: squelch "use 'git add file...'" message when unneeded > > Add a field in wt_status to record if there are any uncached > changes, and use it to decide when there is no point to add the > "use 'git add'" message. Commit 6e458bf63f48fb7d15cb70ad7c7b7b71915d94a2 in next is already doing exactly that. Or am I missing something?