From: Juergen Ruehle <j.ruehle@bmiag.de>
Date: Tue, 08 Aug 2006 18:34:24 GMT
Subject: Re: [PATCH 2/2] builtin git-mv: support moving directories
Message-ID: <17624.55600.423000.61479@lapjr.intranet.kiel.bmiag.de>
In-Reply-To: <Pine.LNX.4.63.0607261941210.29667@wbgn013.biozentrum.uni-wuerzburg.de>

This might have been fixed already (my tree is a couple of days old),
but the strcat fails for me, because the alloced memory is not
cleared.

Johannes Schindelin writes:
 > +static const char *add_slash(const char *path)
 > +{
 > +	int len = strlen(path);
 > +	if (path[len - 1] != '/') {
 > +		char *with_slash = xmalloc(len + 2);
 > +		memcpy(with_slash, path, len);
 > +		strcat(with_slash + len, "/");
 > +		return with_slash;
 > +	}
 > +	return path;
 > +}

perhaps morph the strcat into a memcopy or append the slash and the
NUL manually?

  jr