From: Eslam reda ragheb via GitGitGadget Date: Thu, 26 Feb 2026 21:14:43 GMT Subject: [PATCH v4 06/10] repo: add aggregate structure totals to keyvalue output Message-ID: <1751181950734d2571ef85a419ef62000458bd39.1772140487.git.gitgitgadget@gmail.com> In-Reply-To: From: Eslam reda ragheb Expose aggregate totals alongside per-type values in structure keyvalue/nul output: total references, total objects, total inflated size, and total disk size. These totals remove the need for callers to recompute sums externally. Keeping aggregate and per-type values in the same output format improves script ergonomics. It also keeps machine-readable output aligned with what table mode summarizes for humans. Signed-off-by: Eslam reda ragheb --- builtin/repo.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/builtin/repo.c b/builtin/repo.c index f92c209469..cb70171412 100644 --- a/builtin/repo.c +++ b/builtin/repo.c @@ -824,9 +824,16 @@ static void stats_table_clear(struct stats_table *table) static void structure_keyvalue_print(struct repo_structure *stats, char key_delim, char value_delim) { + size_t references_count_total = get_total_reference_count(&stats->refs); + size_t object_count_total = get_total_object_values(&stats->objects.type_counts); + size_t inflated_size_total = get_total_object_values(&stats->objects.inflated_sizes); + size_t disk_size_total = get_total_object_values(&stats->objects.disk_sizes); size_t max_inflated_size = get_max_object_value(&stats->objects.max_inflated_sizes); size_t max_disk_size = get_max_object_value(&stats->objects.max_disk_sizes); + printf("references.count%c%" PRIuMAX "%c", key_delim, + (uintmax_t)references_count_total, value_delim); + printf("references.branches.count%c%" PRIuMAX "%c", key_delim, (uintmax_t)stats->refs.branches, value_delim); printf("references.tags.count%c%" PRIuMAX "%c", key_delim, @@ -836,6 +843,9 @@ static void structure_keyvalue_print(struct repo_structure *stats, printf("references.others.count%c%" PRIuMAX "%c", key_delim, (uintmax_t)stats->refs.others, value_delim); + printf("objects.count%c%" PRIuMAX "%c", key_delim, + (uintmax_t)object_count_total, value_delim); + printf("objects.commits.count%c%" PRIuMAX "%c", key_delim, (uintmax_t)stats->objects.type_counts.commits, value_delim); printf("objects.trees.count%c%" PRIuMAX "%c", key_delim, @@ -845,6 +855,9 @@ static void structure_keyvalue_print(struct repo_structure *stats, printf("objects.tags.count%c%" PRIuMAX "%c", key_delim, (uintmax_t)stats->objects.type_counts.tags, value_delim); + printf("objects.inflated_size%c%" PRIuMAX "%c", key_delim, + (uintmax_t)inflated_size_total, value_delim); + printf("objects.commits.inflated_size%c%" PRIuMAX "%c", key_delim, (uintmax_t)stats->objects.inflated_sizes.commits, value_delim); printf("objects.trees.inflated_size%c%" PRIuMAX "%c", key_delim, @@ -865,6 +878,9 @@ static void structure_keyvalue_print(struct repo_structure *stats, printf("objects.tags.max_inflated_size%c%" PRIuMAX "%c", key_delim, (uintmax_t)stats->objects.max_inflated_sizes.tags, value_delim); + printf("objects.disk_size%c%" PRIuMAX "%c", key_delim, + (uintmax_t)disk_size_total, value_delim); + printf("objects.max_disk_size%c%" PRIuMAX "%c", key_delim, (uintmax_t)max_disk_size, value_delim); printf("objects.commits.max_disk_size%c%" PRIuMAX "%c", key_delim, -- gitgitgadget