From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Wed, 04 Dec 2024 20:44:26 GMT
Subject: Re: [PATCH v2 3/3] remote set-head: set followRemoteHEAD to "warn" if "always"
Message-ID: <173ea521-6a2e-45aa-ae5e-4da99060cc4f@app.fastmail.com>
In-Reply-To: <xmqqh67j2ndc.fsf@gitster.g>

On Wed, Dec 4, 2024, at 21:40, Junio C Hamano wrote:
> "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:
>
>> On Wed, Dec 4, 2024, at 11:39, Bence Ferdinandy wrote:
>>> diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh
>>> index 7411aa770d..daf70406be 100755
>>> --- a/t/t5505-remote.sh
>>> +++ b/t/t5505-remote.sh
>>> @@ -504,6 +504,17 @@ test_expect_success 'set-head --auto has no
>>> problem w/multiple HEADs' '
>>>  	)
>>>  '
>>>
>>> +test_expect_success 'set-head changes followRemoteHEAD always to warn' '
>>> +	(
>>> +		cd test &&
>>
>> I think you need to `cd` in a subshell here.  See `t/README`, “Don't
>> chdir around in tests.”.
>
> Puzzled.  Isn't this inside a (subshell) already?

Aha, then I didn’t read the context properly.