From: Thalia Archibald <thalia@archibald.dev>
Date: Wed, 10 Apr 2024 10:07:13 GMT
Subject: Re: [PATCH v2 2/8] fast-import: directly use strbufs for paths
Message-ID: <17089372-8AF1-49A5-A582-8153E87380AE@archibald.dev>
In-Reply-To: <ZhYxP42Br2h1mq5r@tanuki>

On Apr 9, 2024, at 23:27, Patrick Steinhardt <ps@pks.im> wrote:
> On Mon, Apr 01, 2024 at 09:03:06AM +0000, Thalia Archibald wrote:
>> 
>> + parse_path_eol(&path, p
>> , "path");
> 
> This looks weird. Did you manually edit the patch or is there some weird
> character in here that breaks diff generation?
> 
>> + tree_content_get(&b-
>>> branch_tree, source.buf, &leaf, 1);
> 
> Same here. Is your mail agent maybe wrapping lines?
> 
>> - s
>> trbuf_reset(&uq);
> 
> And here.
> 
> Other than those formatting issues this patch looks fine to me.

I’m not able to reproduce these rewrapping issues anywhere I view this email: in
my outbox, inbox, or the archive. I think it’s on your end.

https://lore.kernel.org/git/82a6f53c1326a420348eb70461f5929340a930d3.1711960552.git.thalia@archibald.dev/

Thalia