From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Fri, 02 Oct 2015 10:08:24 GMT
Subject: Re: [PATCH/RFC 2/2] sha1_file: set packfile to O_CLOEXEC at open
Message-ID: <16e4ef29524283f51b2fa00e536cf153@dscho.org>
In-Reply-To: <1443670163-31193-3-git-send-email-max@max630.net>

Hi Max,

On 2015-10-01 05:29, Max Kirillov wrote:
> Windows does not support setting O_CLOEXEC by fcntl,
> but there is an open flag O_NOINHERIT which results in same
> behaviour. Use it in git_open_noatime() and also bring
> setting O_CLOEXEC there also to make it consistent. Rename
> the function to git_open_noatime_cloexec(), to avoid confusion.

Which problem does this solve? I am actually suspecting that this will rather cause problems because now `exec()`ing children might cause bogus file descriptors to be still held on.

So I would recommend to drop this patch. It is not needed to fix the reported bug.

Ciao,
Dscho