From: Paul-Sebastian Ungureanu Date: Thu, 28 Jun 2018 22:51:46 GMT Subject: Re: [PATCH v6 2/4] stash: convert drop and clear to builtin Message-ID: <16aa7eed-19af-9793-508e-a13caef020a2@gmail.com> In-Reply-To: Hi, On 27.06.2018 01:17, Johannes Schindelin wrote: > I thought you had introduced `get_oidf()` specifically so you could avoid > the `rev-parse` call... `get_oidf(&dummy_oid, "%s@{0}", ref_stash)` should > do this, right? We discussed this over the IRC channel, but since not everybody might follow the chat, I would like to put it also here. The main reason why `get_oidf()` was introduced is to make `assert_stash_like()` less tedious. I am sure that this is not the only place where this function could be useful. Over the last weeks, I have been working in parallel on adding a new flag (`GET_OID_GENTLY`) for `get_oid_with_context()`. By using this flag, the `rev-parse` call could be replaced with an internal API call. I hope that I will be able to send this patch soon enough. Best regards, Paul