From: Lanny Ripple Date: Thu, 31 May 2012 19:21:16 GMT Subject: Re: Bug: rebase when an author uses accents in name on MacOSx Message-ID: <168277BB-0E71-4987-A2BE-6202034A96F1@spotinfluence.com> In-Reply-To: <7vd35k6w0i.fsf@alter.siamese.dyndns.org> You have three recent instances where people have bumped into this with sed. (And yes on reporting it to the packaging project.) It seems to me leaving a breadcrumb so that folks can figure out what's going on without having to bother the list would be a win for everyone. And yes, if any and all uses of POSIX tools started showing up with some frequency then I think the same breadcrumb win/win logic would apply. Enjoy, -ljr --- Lanny Ripple lanny@spotinfluence.com On May 31, 2012, at 1:33 PM, Junio C Hamano wrote: > Lanny Ripple writes: > >> Perhaps the error message in git-am could be modified to indicate >> sed is a suspect?. E.g., >> >> lanny(master); git rebase master rl-clean292 >> First, rewinding head to replay your work on top of it... >> /sw/lib/git-core/git-am: line 692: Leblond: command not found >> Patch does not have a valid e-mail address. (Used /sw/bin/sed found on PATH). >> ^ ^ ^ ^ ^ ^ ^ ^ ^ ^ ^ >> lanny((ae6c220...)|REBASE); > > Hrm, that does not sound an attractive way going forward. > > Do we have to suspect any and all uses of POSIX tools, just in case > somebody installs a broken implementation from random places? Is > sed the only thing that is possibly broken? > > By the way, have you filed a bug report to whoever supplied your /sw/bin/sed? > >