From: Ben Keene Date: Fri, 13 Dec 2019 19:42:44 GMT Subject: Re: [PATCH v5 00/15] git-p4.py: Cast byte strings to unicode strings in python3 - Code Review Message-ID: <16668dda-391d-275d-8588-cb1affb35f44@gmail.com> In-Reply-To: <7dd1ccdf-7c11-6027-c0b2-0bd95077ff72@gmail.com> On 12/12/2019 9:13 AM, Ben Keene wrote: > > On 12/11/2019 5:30 PM, Yang Zhao wrote: >> On Wed, Dec 11, 2019 at 1:46 PM Junio C Hamano >> wrote: >>> Luke Diamand writes: >>> >>>> On Wed, 11 Dec 2019 at 17:57, Junio C Hamano >>>> wrote: >>>>> Denton Liu writes: >>>>> >>>>>> On Wed, Dec 11, 2019 at 08:54:49AM -0800, Junio C Hamano wrote: >>>>>>  From what I can tell, Ben agreed to have this series superseded >>>>>> by Yang >>>>>> Zhao's competing series[1]. >>>>> OK.  Let me not worry about this one, then, at least not yet. >>>>> >>>> Oh, I hadn't seen Yang's python3 changes! >> ... >>>> What do we need to do to get these ready for merging? >>> Somebody needs to take the ownership of the topic---we cannot afford >>> to have two independently made topics competing reviewers' attention. >>> >>> If Ben wants to drop his version and instead wants to use Yang's >>> ones, that's OK but Ben probably is in a lot better position than >>> bystanders like me to review and comment on Yang's to suggest >>> improvements, if he hasn't done so.  The same for those who reviewed >>> Ben's series earlier. >>> >>> It would make sure that the single topic a combined effort to >>> produce the best of both topics.  If there is something Ben's >>> patches did that is lacking in Yang's, it may be worth rebuilding it >>> on top of Yang's series. I reviewed Yang's changes and added comments to his commits in GitHub. Except for using the version number instead of feature mapping, all of his changes are much simpler and cleaner than I was proposing and I expect will get adoption more quickly. I recommend the inclusion of the one change I added previously that removes the need for the basestring entirely. This moots some of need for the version checking. Kind regards, Ben