From: Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>
Date: Fri, 04 Sep 2015 08:30:13 GMT
Subject: Re: [PATCH v5] git-p4: add config git-p4.pathEncoding
Message-ID: <1646294553.1067005.1441355413320.JavaMail.zimbra@ensimag.grenoble-inp.fr>
In-Reply-To: <5E77893F-8E13-4696-B7A6-46E10FE41989@gmail.com>

Lars Schneider <larsxschneider@gmail.com> writes:

> > Hi Lars,
> >
> > Lars Schneider <larsxschneider@gmail.com> writes:
> >
> >> +test_expect_success 'Clone repo containing iso8859-1 encoded paths with git-p4.pathEncoding' '
> >> +
> >> +        test_when_finished cleanup_git &&
> >> +        (
> >> +                cd "$git" &&
> >> +                git init . &&
> >> +                git config git-p4.pathEncoding iso8859-1 &&
> >
> > Wouldn't 'test_config' be better here?
> >
> If I got Eric’s explanation right in "[PATCH v1] t9821: use
> test_config” then we should not use “test_config” here?

After reading Eric's point of view, I agree with him about this.

So, sorry for the noise, now I'll know better in the future when
to use and not use 'test_config'.

Thanks,
Rémi