From: Derrick Stolee Date: Fri, 20 Jul 2018 16:57:45 GMT Subject: Re: [PATCH 5/8] commit-graph: not compatible with replace objects Message-ID: <16007477-d22a-4a3b-87db-07f11abdfb7f@gmail.com> In-Reply-To: On 7/20/2018 12:49 PM, Stefan Beller wrote: >> Thanks, Peff, for improving the check_replace_refs interaction [1]. >> >> Since this series now has two dependencies (including Stefan's ref-store >> fix [2] that I had included in my v1), I'll let those topics settle >> before I send a new v2. > FYI: I have not been working on, nor plan to work on (in the short term) > on the ref store fix series, which needs another abstraction layer IIUC to > make it easier to integrate such a thing as well as extend the series to all > functions in the refstore. > > Feel free to take over that series partially (and defer the extension for > all functions in the ref store until later) ? OK. Thanks for letting me know. Perhaps I'll give it a try to pass the repository struct in the cbdata for the function pointers, as a minimum amount of change option. Thanks, -Stolee